Clean up minified and non-minified sources for wtb#203
Open
camillobruni wants to merge 4 commits intoWebKit:mainfrom
Open
Clean up minified and non-minified sources for wtb#203camillobruni wants to merge 4 commits intoWebKit:mainfrom
camillobruni wants to merge 4 commits intoWebKit:mainfrom
Conversation
✅ Deploy Preview for webkit-jetstream-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
danleh
reviewed
Oct 15, 2025
Contributor
danleh
left a comment
danleh
left a comment
There was a problem hiding this comment.
Minor nit: typo in the commit/PR title (wbt -> wtb)
Quick questions (I don't really know these JS line items very well):
- Why do we have these new
web-tooling-benchmark/dist/*.LICENSE.txtfiles? Were the sources updated as well, besides the build scripts? - IIUC, the
.map.zfiles are source maps to map minified JS code back to the original ones, but only the minified ones are checked into the repo, right? In that case, should we remove.map.zfiles from the repo as well?
camillobruni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.